Implement Crashlytics Unity ODFs #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrober
force-pushed
the
crashlytics-fatals
branch
from
1eb32dd to
c3bef10
Compare
mrober
changed the title
cynthiajoan
reviewed
Jan 5, 2023
| // clang-format on | ||
| METHOD_LOOKUP_DECLARATION(crashlytics_core, | ||
| METHOD_LOOKUP_NONE, CRASHLYTICS_CORE_FIELDS) | ||
| CRASHLYTICS_CORE_METHODS, |
Contributor
There was a problem hiding this comment.
what the reason of making this change?
Contributor
Author
There was a problem hiding this comment.
The logFatalException method is an internal api of CrashlyticsCore, not a public api of Crashlytics. So we added it here so we can call it via jni.
cynthiajoan
reviewed
Jan 5, 2023
cynthiajoan
approved these changes
Jan 5, 2023
Contributor
cynthiajoan
left a comment
cynthiajoan
left a comment
There was a problem hiding this comment.
LGTM in general with some minor questions.
* [crashlytics ondemand fatals]fix the fatal logic * remove RecordCustomException and System.Environment.StackTrace frame for fault blame on crashlytics sdk
themiswang
reviewed
Jan 13, 2023
themiswang
reviewed
Jan 13, 2023
cynthiajoan
approved these changes
Jan 13, 2023
themiswang
approved these changes
Jan 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Crashlytics Unity ODFs for iOS and Android.
Design doc: go/crashlytics-unity-fatals
API review: go/crashlytics-unity-fatals-api