[Crashlytics fatals] Add iOS implementation #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrober
approved these changes
Jan 4, 2023
mrober
added a commit
that referenced
this pull request
Jan 13, 2023
* Implement ODFs for Android * Update ReportUncaughtExceptionsAsFatal doc, get, set. * [Crashlytics fatals] Add iOS implementation (#589) * [crashlytics ondemand fatals]fix the fatal logic (#598) * [crashlytics ondemand fatals]fix the fatal logic * remove RecordCustomException and System.Environment.StackTrace frame for fault blame on crashlytics sdk * Fine tune how we handle empty stack traces on Android. Co-authored-by: themiswang <themisw@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add iOS implementation for Crashlytics on-demand fatals
Note: on main this pr #560 seems block build for iOS https://screenshot.googleplex.com/AuVq3ZxZnpvLDg7, the committed person is OOO now and I'll followup once he comes back from vacation. Any commit before that on main should be able to build the iOS plug-in