[crashlytics ondemand fatals]fix the fatal logic #598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themiswang
commented
Jan 13, 2023
| LoggedException loggedExceptionWithCurrentStackTrace = new LoggedException(loggedException.Name, loggedException.Message, currentStackTrace); | ||
| parsedStackTrace = loggedExceptionWithCurrentStackTrace.ParsedStackTrace; | ||
|
|
||
| if (parsedStackTrace.Length > 2) { |
Contributor
Author
There was a problem hiding this comment.
If we don't add this logic, the stack trace will look like this as it still blame on crashlytics frame:
Remove these two frame for logging purpose then here is the result:
themiswang
force-pushed
the
crashlytics-fatals-ios
branch
from
a310a71 to
7f3caec
Compare
…for fault blame on crashlytics sdk
themiswang
force-pushed
the
crashlytics-fatals-ios
branch
from
7f3caec to
5e200f6
Compare
mrober
approved these changes
Jan 13, 2023
github-actions
bot
added
the
tests: in-progress
❌ Integration test FAILEDRequested by @firebase-workflow-trigger[bot] on commit 5e200f6
|
firebase-workflow-trigger
bot
removed
the
tests: in-progress
mrober
added a commit
that referenced
this pull request
Jan 13, 2023
* Implement ODFs for Android * Update ReportUncaughtExceptionsAsFatal doc, get, set. * [Crashlytics fatals] Add iOS implementation (#589) * [crashlytics ondemand fatals]fix the fatal logic (#598) * [crashlytics ondemand fatals]fix the fatal logic * remove RecordCustomException and System.Environment.StackTrace frame for fault blame on crashlytics sdk * Fine tune how we handle empty stack traces on Android. Co-authored-by: themiswang <themisw@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix iOS fatal for on demand
Add current stack trace if there is empty stack trace in exception
Testing
Tested exception with stack trace:
https://screenshot.googleplex.com/43Grf4RVMDd5Fzn
Tested exception without stack trace:
https://screenshot.googleplex.com/BNWeCg59nHA46Lt