feat(sql_connect): merge "X-Client-Platform" header into "X-Client-Version" - #18502
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
This PR updates the gRPC metadata in
firebase_data_connectby merging theX-Client-Platformheader into theX-Client-Versionheader (formatting asflutter/<version>) and removing the standaloneX-Client-Platformheader.This is an update to PR #18484 which was merged yesterday and added both of these headers. This update was made to accommodate the firebase-js-sdk because the "X-Client-Platform" header causes the CORS OPTIONS preflight request to fail with a 403 "Permission Denied" error due to that header being absent from Google's list of whitelisted CORS headers. See firebase/firebase-js-sdk#10217 for a few more details, if interested. Note that this exact problem affects this flutter sdk when running in a web browser, so the fix is critical here in this repository too.
Highlights
X-Client-Versionheader (e.g.flutter/<version>) and removed the separateX-Client-Platform(x-client-platform) header.X-Client-Versionheader value format.