Skip to content

feat(sql_connect): merge "X-Client-Platform" header into "X-Client-Version" - #18502

Merged
dconeybe merged 1 commit into
mainfrom
dconeybe/dataconnect/CloudMonitoringHeaders2
Jul 30, 2026
Merged

feat(sql_connect): merge "X-Client-Platform" header into "X-Client-Version"#18502
dconeybe merged 1 commit into
mainfrom
dconeybe/dataconnect/CloudMonitoringHeaders2

Conversation

@dconeybe

Copy link
Copy Markdown
Contributor

This PR updates the gRPC metadata in firebase_data_connect by merging the X-Client-Platform header into the X-Client-Version header (formatting as flutter/<version>) and removing the standalone X-Client-Platform header.

This is an update to PR #18484 which was merged yesterday and added both of these headers. This update was made to accommodate the firebase-js-sdk because the "X-Client-Platform" header causes the CORS OPTIONS preflight request to fail with a 403 "Permission Denied" error due to that header being absent from Google's list of whitelisted CORS headers. See firebase/firebase-js-sdk#10217 for a few more details, if interested. Note that this exact problem affects this flutter sdk when running in a web browser, so the fix is critical here in this repository too.

Highlights

  • Header Consolidation: Merged the platform identifier into the X-Client-Version header (e.g. flutter/<version>) and removed the separate X-Client-Platform (x-client-platform) header.
  • Test Updates: Updated test suites to verify the new X-Client-Version header value format.

@dconeybe dconeybe self-assigned this Jul 30, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@stephenarosaj stephenarosaj left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dconeybe
dconeybe merged commit 049fe5e into main Jul 30, 2026
40 of 46 checks passed
@dconeybe
dconeybe deleted the dconeybe/dataconnect/CloudMonitoringHeaders2 branch July 30, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants