fix(core,web): preserve non-JavaScript app errors - #18552
Conversation
Avoid masking Dart exceptions with unsafe JSError casts when resolving Firebase apps.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 馃憤 and 馃憥 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
Use isA to distinguish JavaScript objects from Dart exceptions without suppressing interop runtime-check lints.
Description
FirebaseCoreWeb.app()and secondary-app initialization cast every caught exception toJSError, which could mask Dart exceptions produced byguardNotInitializedwith an unrelatedTypeError. This change rethrows non-JavaScript exceptions unchanged while preserving the existing Firebase JavaScript error mapping, and adds a browser regression test for[core/not-initialized].Verified with
flutter test --platform chromeandflutter analyzeinpackages/firebase_core/firebase_core_web.Related Issues
as JSErrorcast (same pattern as #18176, not covered by that fix)聽#18548Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?