Skip to content

fix(core,web): preserve non-JavaScript app errors - #18552

Merged
SelaseKay merged 2 commits into
mainfrom
fix/issue-18548
Aug 10, 2026
Merged

fix(core,web): preserve non-JavaScript app errors#18552
SelaseKay merged 2 commits into
mainfrom
fix/issue-18548

Conversation

@SelaseKay

@SelaseKay SelaseKay commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Description

FirebaseCoreWeb.app() and secondary-app initialization cast every caught exception to JSError, which could mask Dart exceptions produced by guardNotInitialized with an unrelated TypeError. This change rethrows non-JavaScript exceptions unchanged while preserving the existing Firebase JavaScript error mapping, and adds a browser regression test for [core/not-initialized].

Verified with flutter test --platform chrome and flutter analyze in packages/firebase_core/firebase_core_web.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Avoid masking Dart exceptions with unsafe JSError casts when resolving Firebase apps.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 馃憤 and 馃憥 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Comment thread packages/firebase_core/firebase_core_web/lib/src/firebase_core_web.dart Outdated
Use isA to distinguish JavaScript objects from Dart exceptions without suppressing interop runtime-check lints.
@SelaseKay
SelaseKay merged commit e6943a6 into main Aug 10, 2026
112 of 113 checks passed
@SelaseKay
SelaseKay deleted the fix/issue-18548 branch August 10, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[firebase_core_web]: FirebaseCoreWeb.app() masks the real error with an unsafe as JSError cast (same pattern as #18176, not covered by that fix)

3 participants