Skip to content

fix(firestore, android): defer transaction cleanup until stream cancellation - #18553

Merged
SelaseKay merged 1 commit into
mainfrom
fix/issue-18546
Aug 10, 2026
Merged

fix(firestore, android): defer transaction cleanup until stream cancellation#18553
SelaseKay merged 1 commit into
mainfrom
fix/issue-18546

Conversation

@SelaseKay

Copy link
Copy Markdown
Contributor

Description

On Android, transaction event channels were unregistered immediately after native completion, so Dart's subsequent stream cancellation reached no handler and reported a MissingPluginException even though the transaction succeeded. This PR defers transaction cleanup until the Dart EventChannel subscription is cancelled, avoids recursive cancellation during plugin-wide listener disposal, and adds Android integration coverage for the teardown path.

The targeted regression test and the complete transaction integration group pass on Android.

Related Issues

Fixes #18546

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

…llation

Keep the transaction event channel registered until Dart cancels its subscription so successful transactions do not report MissingPluginException.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@SelaseKay
SelaseKay merged commit f949c23 into main Aug 10, 2026
46 of 48 checks passed
@SelaseKay
SelaseKay deleted the fix/issue-18546 branch August 10, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cloud_firestore][android] MissingPluginException on transaction channel cancel after every runTransaction since 6.8.0 (#18475)

3 participants