fix(firestore, android): defer transaction cleanup until stream cancellation - #18553
Conversation
…llation Keep the transaction event channel registered until Dart cancels its subscription so successful transactions do not report MissingPluginException.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
Description
On Android, transaction event channels were unregistered immediately after native completion, so Dart's subsequent stream cancellation reached no handler and reported a
MissingPluginExceptioneven though the transaction succeeded. This PR defers transaction cleanup until the DartEventChannelsubscription is cancelled, avoids recursive cancellation during plugin-wide listener disposal, and adds Android integration coverage for the teardown path.The targeted regression test and the complete transaction integration group pass on Android.
Related Issues
Fixes #18546
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?