Skip to content

feat(messaging,ios): migrate example iOS runner from ObjC to Swift - #18578

Merged
SelaseKay merged 1 commit into
mainfrom
fix/issue-13059
Aug 20, 2026
Merged

feat(messaging,ios): migrate example iOS runner from ObjC to Swift#18578
SelaseKay merged 1 commit into
mainfrom
fix/issue-13059

Conversation

@SelaseKay

@SelaseKay SelaseKay commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Description

Migrates the firebase_messaging example iOS runner from the old Objective-C template to Swift, matching what flutter create generates and the UIScene migration guide.

The example already used FlutterSceneDelegate in Info.plist. This change replaces AppDelegate.h / AppDelegate.m / main.m with AppDelegate.swift that:

  • conforms to FlutterImplicitEngineDelegate and registers plugins in didInitializeImplicitFlutterEngine
  • still calls FLTFirebaseMessagingPlugin.configureNotificationCenterDelegate() in didFinishLaunchingWithOptions (Apple requires the notification-center delegate before launch returns)
  • does not add a custom SceneDelegate.swiftInfo.plist continues to use FlutterSceneDelegate directly

Also adds a Swift snippet next to the existing Objective-C one in the plugin README.

This supersedes #18317 by @champ96k, which started this migration. That PR had unresolved review feedback (UIScene AppDelegate adoption, no custom SceneDelegate, keep FlutterSceneDelegate in Info.plist) and had drifted from main (including the later configureNotificationCenterDelegate requirement). This PR applies those review notes on current main.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Keep the UIScene launch path and notification-center delegate setup so the example matches flutter create and Apple's launch requirements.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@SelaseKay
SelaseKay merged commit 69d16e4 into main Aug 20, 2026
31 checks passed
@SelaseKay
SelaseKay deleted the fix/issue-13059 branch August 20, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [firebase_massaging] Example flutter ios build is too old

3 participants