Skip to content

fix(messaging,ios): register for APNs after Dart Firebase.initializeApp() - #18650

Draft
SelaseKay wants to merge 2 commits into
mainfrom
fix/messaging-ios-dart-init-apns-registration
Draft

fix(messaging,ios): register for APNs after Dart Firebase.initializeApp()#18650
SelaseKay wants to merge 2 commits into
mainfrom
fix/messaging-ios-dart-init-apns-registration

Conversation

@SelaseKay

@SelaseKay SelaseKay commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Description

firebase_messaging 16.5.0+ skips registerForRemoteNotifications at launch when Firebase is initialized from Dart only (no GoogleService-Info.plist in the iOS app bundle, no native FirebaseApp.configure()).

isAutoInitEnabled is read in didFinishLaunching, before Dart initializeApp(). Without a bundled plist, [FIRMessaging messaging] is nil, the gate reads as NO, and APNs registration never happens. Result: getAPNSToken() stays null, getToken() throws apns-token-not-set, and onTokenRefresh never fires.

This PR re-runs the auto-init check from pluginConstantsForFIRApp: after firebase_core has configured the default app. Launch-time registration is unchanged for apps that still bundle a plist. FirebaseMessagingAutoInitEnabled = NO is still honored (no registration until setAutoInitEnabled(true)).

Related Issues

Fixes #18643

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, this is not a breaking change.

Test plan

  • Run an iOS device build of this branch with Dart-only Firebase init (no GoogleService-Info.plist in Copy Bundle Resources).
  • getAPNSToken() is non-null and getToken() succeeds without apns-token-not-set.
  • Apps that still bundle GoogleService-Info.plist continue to register at launch.
  • FirebaseMessagingAutoInitEnabled = NO still skips registration until setAutoInitEnabled(true).

…pp()

When Firebase is initialized from Dart without a bundled GoogleService-Info.plist, FIRApp does not exist at launch so isAutoInitEnabled reads as NO and APNs registration is skipped. Re-run the auto-init check once the default app is configured, and keep temporary APNS-REG logs so reporters can confirm registration is requested.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant