Skip to content

fix(firebase_database): List of values erroring on transaction result#7001

Merged
russellwheatley merged 4 commits intomasterfrom
@russell/rtdb-get-bug
Sep 23, 2021
Merged

fix(firebase_database): List of values erroring on transaction result#7001
russellwheatley merged 4 commits intomasterfrom
@russell/rtdb-get-bug

Conversation

@russellwheatley
Copy link
Copy Markdown
Member

Description

transactions don't pass childKeys so we pass the data back as it is.

Related Issues

fixes #6583

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Sep 14, 2021
@russellwheatley russellwheatley changed the title fix(firebase_database): check childKeys available fix(firebase_database): List of primitive values was erroring on transactions Sep 14, 2021
@Salakar Salakar changed the title fix(firebase_database): List of primitive values was erroring on transactions fix(firebase_database): List of values erroring on transaction result Sep 23, 2021
@russellwheatley russellwheatley merged commit 4c2567a into master Sep 23, 2021
@russellwheatley russellwheatley deleted the @russell/rtdb-get-bug branch September 23, 2021 13:20
@tek08 tek08 mentioned this pull request Oct 6, 2021
10 tasks
@firebase firebase locked and limited conversation to collaborators Oct 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [realtime_database] Unhandled Exception: Null check operator used on a null value

2 participants