fix(go/ai): fix race condition in concurrent prompt rendering #3837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple goroutines concurrently called Execute() or Render() on the same Prompt instance, they would mutate shared Message objects, causing race conditions and incorrect rendering results. The bug was in renderMessages() function which directly modified the Content field of Message objects returned from MessagesFn. This caused concurrent renders to interfere with each other. Fixed by creating new Message copies during rendering instead of mutating the originals. This ensures each concurrent render operation gets its own independent Message objects.
Contributor
Author
|
@hugoaguirre Fix the concurrency issue caused by #3780 |
Contributor
Author
|
@hugoaguirre @apascal07 pls review it. |
apascal07
requested review from
apascal07
and removed request for
rutujaD1999
apascal07
reviewed
Nov 24, 2025
apascal07
approved these changes
Nov 24, 2025
Co-authored-by: Alex Pascal <apascal07@gmail.com>
Collaborator
Please run. |
Contributor
Author
|
@apascal07 Thank you for the reminder. I have formatted the code |
hugoaguirre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple goroutines concurrently called Execute() or Render() on the same Prompt instance, they would mutate shared Message objects, causing race conditions and incorrect rendering results.
The bug was in renderMessages() function which directly modified the Content field of Message objects returned from MessagesFn. This caused concurrent renders to interfere with each other.
Fixed by creating new Message copies during rendering instead of mutating the originals. This ensures each concurrent render operation gets its own independent Message objects.