Skip to content

Conversation

@mikepugh
Copy link
Contributor

Bower package moved to geofire-js

Bower package moved to geofire-js
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 77eff96 on mikepugh:patch-2 into bdc2b34 on firebase:master.

@jwngr
Copy link

jwngr commented Aug 27, 2014

I have no idea why this happened... Obviously, we did change the repo name but the name in the bower.json is still "geofire.". Also, geofire-js cannot be found on npmjs.org. But you are certainly right, if I do bower install geofire I get v2.1.1 and if I do bower install geofire-js I get v3.0.0. Do you have any idea how this could have happened?

@mikepugh
Copy link
Contributor Author

When I try bower install geofire on a fresh repo, I get the "readme.md" and "sf-vehicles.png" files which are currently located on the github.com/firebase/geofire repo. I'm guessing this all went down when you guys moved the iOS/Java/JS geofire libs out into their own repos, and started using the original /geofire repo as a pointer ??

@mikepugh
Copy link
Contributor Author

Also, I don't think the name in the bower.json file actually matters. It's whatever you use to register the package via bower register <pkg name> <git endpoint> that matters. So now 'geofire' points to the wrong endpoint in bower.

@jwngr
Copy link

jwngr commented Aug 27, 2014

Thanks for heads up on this @mikepugh! I am merging it in for now. I requested that Bower should update geofire to point to the correct repo here. Then I will change the README back to the old geofire bower package.

jwngr pushed a commit that referenced this pull request Aug 27, 2014
Update readme bower instructions
@jwngr jwngr merged commit ece25a9 into firebase:master Aug 27, 2014
@jwngr
Copy link

jwngr commented Aug 27, 2014

Actually, only the Bower package changed... I'm gonna commit a fix for that in the README.

@mikepugh
Copy link
Contributor Author

No prob - I originally thought this was an intentional move you guys were making so I just assumed you had updated NPM along w/ Bower.

@mikepugh mikepugh deleted the patch-2 branch August 27, 2014 18:19
@jwngr
Copy link

jwngr commented Sep 4, 2014

The package name was finally converted back to geofire. The README has been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants