Address PR feedback for Agent Platform - #1867
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several view models in the FirebaseAIExample app to use the default .agentPlatform() backend initialization instead of explicitly passing the location: "global" parameter. Additionally, it renames the googleAI case display name in BackendOption from "Google AI" to "Gemini Developer API". I have no feedback to provide as there are no review comments.
| enum BackendOption: String, CaseIterable, Identifiable { | ||
| case googleAI = "Google AI" | ||
| case googleAI = "Gemini Developer API" | ||
| case agentPlatform = "Agent Platform Gemini API" |
There was a problem hiding this comment.
Should this be Gemini Enterprise Agent Platform? (I can't remember if there's enough space on screen for that text though.)
There was a problem hiding this comment.
This is consistent with docs and SDKs
|
|
||
| enum BackendOption: String, CaseIterable, Identifiable { | ||
| case googleAI = "Google AI" | ||
| case googleAI = "Gemini Developer API" |
There was a problem hiding this comment.
SGTM, I think it'll be more straightforward for devs to match it up with the text in the Console.
2 participants
Addresses feedback regarding the new Agent Platform syntax: