Security Audit & Remediation: manual-emulator-testing#467
Merged
inlined merged 2 commits intoJul 1, 2026
Conversation
…add local package-lock.json for manual-emulator-testing
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the firebase-tools dependency to version 15.22.1, adds a Node.js engine requirement, and applies code formatting across several files, including fixing invalid HTML tags in index.html. Feedback on the changes highlights that createUserWithEmailAndPassword returns a UserCredential rather than a User object, and that manually calling this.setUser is redundant and can cause duplicate listeners, suggesting its removal.
… duplicate snapshot listeners
morganchen12
approved these changes
Jul 1, 2026
| this.msgInput = ""; | ||
| }, | ||
| signUp: async function() { | ||
| signUp: async function () { |
Contributor
There was a problem hiding this comment.
This and the one below are odd jetski artifacts but for the sake of speed fixing it is optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Audit & Remediation: manual-emulator-testing
A. Previous CVEs
firebase-toolsdependencies and transitives containing critical/high-severity vulnerabilities, including prototype pollution, RCE, and DoS.B. Changes Made
>=22.0.0.firebase-toolsto^15.22.1.public/index.html(unclosed<input>tags using invalid</textarea>).package-lock.jsonwith--no-workspacesto support standalone copy+paste usage of the sample project.C. Remaining CVEs
firebase-tools@15.22.1transitives:tar(high file smuggling/arbitrary file overwrite),tmp(high traversal),vm2(critical sandbox escape RCE),uuid(moderate bounds check),tough-cookie(moderate prototype pollution),yaml(moderate stack overflow),ws(high DoS).D. Introduced CVEs
E. Testing Strategy
npx prettier --check .).