Skip to content

ci: Fir 9443 create nightly jobs #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Dec 13, 2021
Merged

ci: Fir 9443 create nightly jobs #63

merged 18 commits into from
Dec 13, 2021

Conversation

@stepansergeevitch
Copy link
Contributor

@stepansergeevitch stepansergeevitch commented Dec 1, 2021

Created a nightly job for SDK, runs on windows, macos and linux. Uses python 3.7, 3.8, 3.9, 3.10.
Runs code check, unit and integration tests

@stepansergeevitch stepansergeevitch self-assigned this Dec 1, 2021
@stepansergeevitch stepansergeevitch force-pushed the FIR-9443-create-nightly-jobs branch from bcfbd12 to 871874c Compare December 1, 2021 12:36
@eg-firebolt
Copy link
Contributor

eg-firebolt commented Dec 1, 2021

Does the nightly job run against the main branch, a specific release, or something else?

@stepansergeevitch stepansergeevitch force-pushed the FIR-9443-create-nightly-jobs branch from 2e59643 to 57b2fe4 Compare December 8, 2021 12:24
@stepansergeevitch
Copy link
Contributor Author

stepansergeevitch commented Dec 13, 2021

@eg-firebolt Sorry, didn't see your comment. The scheduled nightly job always runs against main branch. Although, it can be run manually against any branch

@stepansergeevitch
Copy link
Contributor Author

stepansergeevitch commented Dec 13, 2021

The job is passing now: https://github.com/firebolt-db/firebolt-python-sdk/actions/runs/1563393534

@stepansergeevitch stepansergeevitch force-pushed the FIR-9443-create-nightly-jobs branch from e527dad to b5d44ac Compare December 13, 2021 10:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

ptiurin
ptiurin approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@ptiurin ptiurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that lgtm

.github/workflows/nightly.yml
Comment on lines 7 to +10
code-check:
runs-on: ubuntu-latest
steps:
- name: Check out code
Copy link
Contributor

@ptiurin ptiurin Dec 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to reuse here .github/workflows/code-check.yml ?

Copy link
Contributor Author

@stepansergeevitch stepansergeevitch Dec 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like how github let's you reuse jobs because you need to specify specific branch/commit when reusing, and you can't just say use the same commit as the calling job. This makes it harder to test jobs on specific branches. That's why I think it's better to avoid reusing jobs when possible

@stepansergeevitch stepansergeevitch merged commit 92ae8cc into main Dec 13, 2021
@stepansergeevitch stepansergeevitch deleted the FIR-9443-create-nightly-jobs branch December 13, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ptiurin ptiurin ptiurin approved these changes

@eg-firebolt eg-firebolt Awaiting requested review from eg-firebolt

Assignees

@stepansergeevitch stepansergeevitch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stepansergeevitch @eg-firebolt @ptiurin