-
Notifications
You must be signed in to change notification settings - Fork 11
ci: Fir 9443 create nightly jobs #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d241422
make python versions string
stepansergeevitch d4fc6f4
remove fail-fast strategy
stepansergeevitch 7df21f4
refactor workflows
stepansergeevitch 4d40ee0
fix workflow paths
stepansergeevitch b56b206
fix typo
stepansergeevitch 3fb1428
revert seprating code-check
stepansergeevitch 520ad4a
fix integration tests reference
stepansergeevitch 0af369c
revert reusing integration tests
stepansergeevitch 725151b
remove workflow call, use js action
stepansergeevitch 455e1f9
improve response error handling
stepansergeevitch bd92ee4
pass db suffix
stepansergeevitch b5db2d5
fix db suffix
stepansergeevitch bc1597a
use js action in integration tests workflow
stepansergeevitch fc40669
reduce max parallel to 4
stepansergeevitch c34a753
fix integration tests action
stepansergeevitch c1a38aa
reduce parallelism to 3
stepansergeevitch 89eca09
reduce parallelism to 2
stepansergeevitch b5d44ac
use master for setup db action
stepansergeevitch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: Python code checks | ||
|
|
||
| on: | ||
| workflow_call: | ||
|
|
||
| jobs: | ||
| check-code: | ||
| steps: | ||
| - name: Check out code | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Set up Python 3.7 | ||
| uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: 3.7 | ||
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install ".[dev]" | ||
|
|
||
| - name: Run pre-commit checks | ||
| uses: pre-commit/action@v2.0.3 | ||
| with: | ||
| extra_args: --all-files | ||
|
|
||
| - name: Type check with mypy | ||
| run: | | ||
| mypy src |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to reuse here .github/workflows/code-check.yml ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like how github let's you reuse jobs because you need to specify specific branch/commit when reusing, and you can't just say use the same commit as the calling job. This makes it harder to test jobs on specific branches. That's why I think it's better to avoid reusing jobs when possible