fix(build): drop zip's C-backed zstd codec, unblock wasm32 builds - #5
Merged
amplitudesxd merged 1 commit intoAug 4, 2026
Merged
Conversation
zip's default features enable zstd (via zstd-sys, a C library), even though anydoc never writes archives outside tests and every format it reads (docx/pptx/xlsx/odt/epub) uses deflate, not zstd. calamine's own zip dependency was already scoped to ["deflate"], this matches it. That C dependency was also why `cargo build --target wasm32-unknown-unknown` failed outright. Pure-Rust deflate has no such problem. 171 unit tests plus the robustness/snapshot suites still pass unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Scopes anydoc's own
zipdependency todefault-features = false, features = ["deflate"], matching thezipdependencycalaminealready uses.Why
#[cfg(test)]fixtures.cargo build --target wasm32-unknown-unknownfails immediately (error: unable to create target: 'No available targets are compatible with triple "wasm32-unknown-unknown"', from clang trying to build the vendored zstd C sources), pure-Rust deflate has no such problem.Testing
cargo test -p anydoc, 171 passed, robustness and snapshot suites greencargo build -p anydoc-node, the Node addon still builds cleancargo build --target wasm32-unknown-unknown -p anydoc, now succeeds (this was the blocker for a wasm binding target, more on that separately)Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.