Skip to content

fix(developer): deduplicate URLs and clean separators - #212

Merged
PhantomInTheWire merged 1 commit into
mainfrom
fix/developer-readable-output
Aug 26, 2026
Merged

fix(developer): deduplicate URLs and clean separators#212
PhantomInTheWire merged 1 commit into
mainfrom
fix/developer-readable-output

Conversation

@PhantomInTheWire

@PhantomInTheWire PhantomInTheWire commented Aug 25, 2026

Copy link
Copy Markdown
Member

Summary

  • omit the bare result URL when the result ID already contains that exact URL
  • skip separators for empty passage blocks
  • leave readable passages intact

Developer search already budgets passages server-side at 4,096 tokens in firecrawl/search#843. The CLI does not add a second cap, matching firecrawl/firecrawl-mcp-server#381.

Verification

  • pnpm run format:check
  • pnpm run type-check
  • pnpm run build
  • pnpm run test (433 passed)

The repository uses separate package-only release PRs. This change does not bump or publish version 1.23.1.

@PhantomInTheWire

Copy link
Copy Markdown
Member Author

@cubic-dev-ai review

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 25, 2026

Copy link
Copy Markdown

@cubic-dev-ai review

@PhantomInTheWire I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread src/commands/developer.ts Outdated
Comment thread src/commands/developer.ts Outdated
Comment thread src/__tests__/commands/developer.test.ts Outdated
@PhantomInTheWire
PhantomInTheWire force-pushed the fix/developer-readable-output branch from f105b98 to a6145c0 Compare August 25, 2026 11:57
@PhantomInTheWire

Copy link
Copy Markdown
Member Author

@cubic-dev-ai review

Please re-review exact head a6145c08440ba0bdbe4c68f80787147b01dc4c39. All three prior findings have fixes and regressions. Format, type-check, build, and 433 tests pass.

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 25, 2026

Copy link
Copy Markdown

@cubic-dev-ai review

Please re-review exact head a6145c08440ba0bdbe4c68f80787147b01dc4c39. All three prior findings have fixes and regressions. Format, type-check, build, and 433 tests pass.

@PhantomInTheWire I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@PhantomInTheWire
PhantomInTheWire force-pushed the fix/developer-readable-output branch from a6145c0 to 1d0d6ef Compare August 25, 2026 21:35
@PhantomInTheWire PhantomInTheWire changed the title fix(developer): bound readable output and deduplicate URLs fix(developer): deduplicate URLs and clean separators Aug 25, 2026
@PhantomInTheWire
PhantomInTheWire merged commit 6a0fac5 into main Aug 26, 2026
8 checks passed
@PhantomInTheWire
PhantomInTheWire deleted the fix/developer-readable-output branch August 26, 2026 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant