Remove explicit annotation on solve() (-> #4638)#5226
Merged
Conversation
angus-g
force-pushed
the
angus-g/4638-solver
branch
from
July 8, 2026 02:41
fb1c345 to
64c8edb
Compare
JHopeCollins
approved these changes
Jul 9, 2026
JHopeCollins
left a comment
JHopeCollins
left a comment
Member
There was a problem hiding this comment.
Yes, great. This shouldn't have been a thing anyway. The less code to maintain the better.
angus-g
force-pushed
the
JHopeCollins/nlvs-hessian-fix
branch
from
July 13, 2026 05:28
62f3a75 to
a9adaa4
Compare
We remove the explicit adjoint annotation on the bare solve() call, relying on the path through the NLVS as the single source of annotation. This simplifies and unifies the code paths, and will ideally allow us to remove the specialised solve blocks.
I don't think this affects anything, but should be there as a convenience function (referenced in the "extract adjoint solutions" notebook).
This is redundant now that it gets routed through the usual cached solver path.
angus-g
force-pushed
the
angus-g/4638-solver
branch
from
July 13, 2026 05:28
ac7c660 to
6dccd06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We remove the explicit adjoint annotation on the bare solve() call, relying on the path through the NLVS as the single source of annotation. This simplifies and unifies the code paths, and will ideally allow us to remove the specialised solve blocks.
I think test failures here are dealt with by #5188.