docs(delegation): document WeightedStrategy object-identity invariant#206
Merged
Conversation
WeightedStrategy dedupes blended scores via id(agent). If a child strategy returns wrapped/forked copies, or if the pool contains two distinct objects for the same logical agent, the blend silently double-counts or drops contributions. Document the invariant so callers wiring up custom strategies don't get surprised.
ancongui
pushed a commit
that referenced
this pull request
May 31, 2026
…note docs(delegation): document WeightedStrategy object-identity invariant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WeightedStrategydedupes per-agent blended scores viaid(agent). That's fine for the typical static pool, but if a child strategy returns a wrapped/forked copy of an agent, or if the pool contains two distinct objects representing the same logical agent, the blend silently double-counts or drops contributions — no error, just wrong scores.Adds a
.. note::block to the class docstring spelling out the invariant so callers wiring up custom strategies don't have to discover it empirically.Docs-only; no behavior change.