Skip to content

docs(delegation): document WeightedStrategy object-identity invariant #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguelgfierro merged 2 commits into from
May 21, 2026
Merged

docs(delegation): document WeightedStrategy object-identity invariant #206

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
587c69e
docs(delegation): note WeightedStrategy uses object identity for dedup
miguelgfierro May 21, 2026
0f42093
Merge branch 'main' into docs/weighted-identity-note
miguelgfierro May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions fireflyframework_agentic/agents/delegation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,17 @@ class WeightedStrategy:

Final candidates are filtered by ``min_score`` and ranked descending.

.. note::
Agents are deduped by Python object identity (``id(agent)``).
Every child strategy must return the *same* ``FireflyAgent``
instances that were passed in — wrapped, forked, or freshly
constructed copies will be treated as different agents and the
blend will silently double-count or drop contributions. The
agent pool itself must also contain each logical agent only
once; a pool with two references to the same object is fine,
a pool with two distinct objects representing the same logical
agent is not.

Parameters:
*weighted: ``(strategy, weight)`` pairs, one per child strategy.
min_score: Drop candidates whose blended score is below this
Expand Down
Loading