Skip to content

BFP-2381: Update with new Auth Service API#128

Merged
MemoAlfa merged 21 commits intomainfrom
nikita/readonly_token
Jun 15, 2025
Merged

BFP-2381: Update with new Auth Service API#128
MemoAlfa merged 21 commits intomainfrom
nikita/readonly_token

Conversation

@nikita-seedlabs
Copy link
Copy Markdown
Contributor

@nikita-seedlabs nikita-seedlabs commented Jun 13, 2025 •
edited
Loading

  • Adds optional readOnly and refreshTokenValidForSeconds parameters to the rust, python and ts sdk when fetching auth token
  • Adds login_v2() function to python sdk to match the rust and ts sdks. Defaults internal switch to current login_v1() function.
  • Fixes python sdk example

@nikita-seedlabs nikita-seedlabs requested review from a team, MemoAlfa and kevin-ip June 13, 2025 22:38
kevin-ip
kevin-ip reviewed Jun 13, 2025
View reviewed changes
Comment thread python/example/main.py
Comment thread python/sdk/src/bluefin_pro_sdk.py Outdated
Comment thread python/sdk/src/bluefin_pro_sdk.py
Comment thread python/sdk/src/bluefin_pro_sdk.py Outdated
Comment thread python/sdk/src/bluefin_pro_sdk.py Outdated
Comment thread python/sdk/src/crypto_helpers/signature.py Outdated
Comment thread resources/auth-api.yaml
nikita-seedlabs
nikita-seedlabs commented Jun 13, 2025
View reviewed changes
Comment thread python/sdk/src/crypto_helpers/signature.py
kevin-ip
kevin-ip approved these changes Jun 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@kevin-ip kevin-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from python perspective

MemoAlfa
MemoAlfa approved these changes Jun 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@MemoAlfa MemoAlfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove login v2

@MemoAlfa MemoAlfa merged commit 0bd6202 into main Jun 15, 2025
@MemoAlfa MemoAlfa deleted the nikita/readonly_token branch June 15, 2025 08:20
MemoAlfa
MemoAlfa reviewed Jun 15, 2025
View reviewed changes
Comment thread python/sdk/src/bluefin_pro_sdk.py
target_account_address: str = None,
debug: bool = False,
colocation_enabled: bool = False,
read_only: bool | None = None,
Copy link
Copy Markdown
Contributor

@MemoAlfa MemoAlfa Jun 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set to false not None

MemoAlfa
MemoAlfa reviewed Jun 15, 2025
View reviewed changes
Comment thread python/sdk/src/bluefin_pro_sdk.py
debug: bool = False,
colocation_enabled: bool = False,
read_only: bool | None = None,
refresh_token_valid_for_seconds: int | None = None,
Copy link
Copy Markdown
Contributor

@MemoAlfa MemoAlfa Jun 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

             refresh_token_valid_for_seconds: int = None,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MemoAlfa MemoAlfa MemoAlfa approved these changes

@kevin-ip kevin-ip kevin-ip approved these changes

Assignees

@jeffs jeffs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nikita-seedlabs @MemoAlfa @kevin-ip @jeffs