Fix async problem found in deposit_to_asset_bank#129
Merged
nikita-seedlabs merged 1 commit intonikita/readonly_tokenfrom Jun 13, 2025
Merged
Fix async problem found in deposit_to_asset_bank#129nikita-seedlabs merged 1 commit intonikita/readonly_tokenfrom
nikita-seedlabs merged 1 commit intonikita/readonly_tokenfrom
Conversation
| # await client.deposit_to_asset_bank("USDC", 10000000000, "0x0000AnyWallet") | ||
| # example of how to deposit into own account for own wallet | ||
| client.deposit_to_asset_bank("USDC", 10000000000, sui_wallet.sui_address) | ||
| await client.deposit_to_asset_bank("USDC", 10000000000, sui_wallet.sui_address) |
Contributor
There was a problem hiding this comment.
does this need to be async in the first place?
Contributor
Author
There was a problem hiding this comment.
Not necessary but the majority of the methods in the client are defined as async. It's better to be consistent.
kevin-ip
force-pushed
the
kevin/readonly_token
branch
from
b77825c to
b44bad5
Compare
nikita-seedlabs
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
self.__rpc_calls.deposit_to_asset_bankis a blocking call, let's wrap it insync_to_asyncto unblock the event loop