Apply routes → services → repositories layering to forms (#640, part 1) - #652
Merged
marcvergees merged 1 commit intoAug 8, 2026
Conversation
marcvergees
merged commit Aug 8, 2026
27c94f9
into
fireform-core:development-approach-b
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of #640 (forms; templates follow in part 2).
Applies the routes → services → repositories layering to the forms routes:
fill orchestration (resolves transcript, calls the existing Controller unchanged,
persists via repository), the submissions list, analytics, and purge logic.
get_submissions_with_template, get_submissions_before).
check, 500 Controller-exception wrapping, AppError bubbling) stay in the route.
Behavior unchanged — 152 tests pass with only mock-location changes (Controller/PROJECT_ROOT
now patched at their new service location), no response-assertion changes. ruff check app/
clean. No direct DB queries remain in forms.py.
Known follow-up: _resolve_project_file/PROJECT_ROOT is temporarily duplicated between
forms.py (untouched delete endpoint) and form.py (purge) — will consolidate when the delete
endpoint moves to the service.
Templates layering is part 2 (separate PR).