[Pipeline B] Route Controller/FileManipulator through FormService (#641) - #655
Merged
marcvergees merged 1 commit intoAug 9, 2026
Conversation
marcvergees
merged commit Aug 9, 2026
8b7a49b
into
fireform-core:development-approach-b
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #641.
The async fill task (app/tasks/fill.py) was constructing Controller() directly and building
its own FormSubmission. It now routes through FormService like the sync path does (after
#640), so Controller is constructed in exactly one place (FormService.init).
Controller and persists the FormSubmission. Both the sync route and the async task use it.
fill_and_persist.
fill_and_persist with the already-resolved transcript (jobs.py resolves up front per [Pipeline B] Wire the fill flow to accept input_id and use the stored transcript #638
— no re-resolution). Job-status handling stays in the task.
untouched — [Pipeline B] Route Controller/FileManipulator through the form service #641 is only the form-fill path.
Behavior unchanged — 152 tests pass (no test changes needed; the task is mocked at the
dispatch boundary). ruff check app/ clean. No Controller() construction remains in
app/tasks/fill.py.