Skip to content

[Pipeline B] Route Controller/FileManipulator through FormService (#641) - #655

Merged
marcvergees merged 1 commit into
fireform-core:development-approach-bfrom
abhishek-8081:issue-641-controller-through-service
Aug 9, 2026
Merged

[Pipeline B] Route Controller/FileManipulator through FormService (#641)#655
marcvergees merged 1 commit into
fireform-core:development-approach-bfrom
abhishek-8081:issue-641-controller-through-service

Conversation

@abhishek-8081

Copy link
Copy Markdown
Collaborator

Closes #641.

The async fill task (app/tasks/fill.py) was constructing Controller() directly and building
its own FormSubmission. It now routes through FormService like the sync path does (after
#640), so Controller is constructed in exactly one place (FormService.init).

Behavior unchanged — 152 tests pass (no test changes needed; the task is mocked at the
dispatch boundary). ruff check app/ clean. No Controller() construction remains in
app/tasks/fill.py.

@marcvergees
marcvergees merged commit 8b7a49b into fireform-core:development-approach-b Aug 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants