Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Conversation

@jasonLaster
Copy link
Contributor

Associated Issue: #2355

Summary of Changes

  • removes search.results because it is too slow
  • the UI now just shows the number of results
  • we should build a better algorithm for getting the match location

@jasonLaster jasonLaster force-pushed the disable-match-index branch from d1a376f to 1791b6d Compare May 25, 2017 18:22
@codecov
Copy link

codecov bot commented May 25, 2017

Codecov Report

Merging #3008 into master will increase coverage by 0.25%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3008      +/-   ##
==========================================
+ Coverage   63.64%   63.89%   +0.25%     
==========================================
  Files          72       72              
  Lines        2517     2504      -13     
  Branches      514      511       -3     
==========================================
- Hits         1602     1600       -2     
+ Misses        915      904      -11
Impacted Files Coverage Δ
src/utils/editor/source-search.js 9.83% <0%> (+0.81%) ⬆️
src/test/tests-setup.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 399b863...1791b6d. Read the comment docs.

Copy link
Contributor

@wldcordeiro wldcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, that bit of code had issues and I support coming back to this with a more efficient solution later.

@jasonLaster jasonLaster merged commit 197f9f0 into firefox-devtools:master May 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants