This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Fix ObjectInspector indent issue. #5468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In firefox-devtools#5269, we introduced an override for non-expandable nodes on the Tree component, since we don't use the provided arrow in the project. But, by doing that, we introduced a regression in the ObjectInspector indent, since it also uses the Tree component. Here we add more specificity to the overriding rule so we don't target ObjectInspector anymore.
jasonLaster
approved these changes
Feb 19, 2018
jasonLaster
pushed a commit
that referenced
this pull request
Feb 20, 2018
In #5269, we introduced an override for non-expandable nodes on the Tree component, since we don't use the provided arrow in the project. But, by doing that, we introduced a regression in the ObjectInspector indent, since it also uses the Tree component. Here we add more specificity to the overriding rule so we don't target ObjectInspector anymore.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5269, we introduced an override for non-expandable nodes on the Tree component,
since we don't use the provided arrow in the project.
But, by doing that, we introduced a regression in the ObjectInspector indent,
since it also uses the Tree component.
Here we add more specificity to the overriding rule so we don't target ObjectInspector anymore.
Screenshots