This repository was archived by the owner on Jan 11, 2023. It is now read-only.
[Breakpoints] fix breakpoint context menu logic#7271
Merged
jasonLaster merged 2 commits intofirefox-devtools:masterfrom Nov 15, 2018
Merged
[Breakpoints] fix breakpoint context menu logic#7271jasonLaster merged 2 commits intofirefox-devtools:masterfrom
jasonLaster merged 2 commits intofirefox-devtools:masterfrom
Conversation
jasonLaster
approved these changes
Nov 15, 2018
| selectMenuItem(dbg, 3); | ||
| await waitForState(dbg, state => | ||
| dbg.selectors.getBreakpointsList(state) | ||
| .every(bp => (bp.location.line === 1) === bp.disabled) |
Contributor
There was a problem hiding this comment.
okay, this is the craziest thing I've seen in awhile, but it's a test so lets go crazy
Contributor
|
This is beautiful. I love that you opened two PRs by the way, that really helps keep things moving |
loganfsmyth
pushed a commit
that referenced
this pull request
Nov 16, 2018
* fix breakpoint context menu logic for finding other breakpoints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7268
Summary of Changes