Skip to content

Clarify that CPU is between samples and category&stack are at sample time #3240

Description

@squelart

When CPU numbers are shown, the tooltip looks like this:
profiler-cpu-tooltip
So it's something like this:

Category: [] Layout...
CPU Usage: 97% (...)
Stack:
parse_into()...
...

I'm concerned that we're mixing two "domains" of information, and it may give the wrong impression, e.g.: "Wow, this parse_into in layout is taking 97% of a CPU!".
But in fact, all we can say from this data is: Since the previous sample and now, we have used 97% of a CPU; And at this exact sample time we were calling parse_into in layout.

So I think we should clarify the difference.
Suggestion:

CPU Usage since previous sample: 97% (...)
.....................................................................................
Sample at time: 0.8465s
Category: [] Layout...
Stack:
parse_into()...
...

This clearly separates the more continuous CPU numbers from the point-like sample data.

As a bonus it shows the precise timestamp. I don't know how valuable that is, but for example it could help find markers at that time in the Marker Table.

┆Issue is synchronized with this Jira Task

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedThings ready to be worked on by anyone. Issues must include instructions on how to complete the taskpolishSmall features or changes that do not require planning to work on. These help out our end users.timelineIssues related to the header timeline view

    Type

    No type

    Fields

    Priority

    None yet

    Jira

    None yet

    Severity

    None yet

    Estimate

    None yet

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions