Skip to content

Create the Network track from the timeline-network schema display location - #6224

Merged
fatadel merged 1 commit into
firefox-devtools:mainfrom
fatadel:issue-6194-2
Aug 4, 2026
Merged

Create the Network track from the timeline-network schema display location#6224
fatadel merged 1 commit into
firefox-devtools:mainfrom
fatadel:issue-6194-2

Conversation

@fatadel

@fatadel fatadel commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Main | Deploy preview

Profile

The Network track was added whenever a thread had a marker with data.type === 'Network'. Add a timeline-network marker-schema display location, declare it on the Network schema, and drive track creation from that location so Network handling no longer hardcodes the payload type.

The combined (front-end + Gecko) schema list is used so the front-end Network schema override always contributes its timeline-network location.

Bump the processed profile format version to 69 for the new display location.

Part of #6194

@fatadel
fatadel requested review from canova and mstange July 28, 2026 09:20
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.69%. Comparing base (7472784) to head (9710c21).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6224   +/-   ##
=======================================
  Coverage   83.68%   83.69%           
=======================================
  Files         348      348           
  Lines       37396    37405    +9     
  Branches    10499    10401   -98     
=======================================
+ Hits        31296    31305    +9     
  Misses       5673     5673           
  Partials      427      427           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/types/markers.ts
@fatadel
fatadel requested a review from canova July 31, 2026 10:27
Comment thread src/profile-logic/processed-profile-versioning.ts
…ation

The Network track was added whenever a thread had a marker with
data.type === 'Network'. Add a timeline-network marker-schema display
location, declare it on the Network schema, and drive track creation
from that location so Network handling no longer hardcodes the payload
type.

The combined (front-end + Gecko) schema list is used so the front-end
Network schema override always contributes its timeline-network
location.

Bump the processed profile format version to 69 for the new display
location.

Part of firefox-devtools#6194
@fatadel
fatadel requested a review from canova August 4, 2026 10:10
@fatadel
fatadel merged commit 9c69b7c into firefox-devtools:main Aug 4, 2026
23 checks passed
@fatadel
fatadel deleted the issue-6194-2 branch August 4, 2026 12:13
@canova canova mentioned this pull request Aug 10, 2026
canova added a commit that referenced this pull request Aug 10, 2026
Changes:

[fatadel] Create the Network track from the timeline-network schema
display location (#6224)
[Markus Stange] Only call `getRawFrameTableBuilderWithExistingContents`
once per symbolication batch. (#6233)
[fatadel] Improve discoverability of downloading a local profile (#6216)
[Nazım Can Altınova] Handle the cli daemon startup failures more
gracefully with better errors (#6241)
[Nazım Can Altınova] Add the ability to apply source maps from the CLI
(#6229)
[Nazım Can Altınova] Handle Text and Log marker payloads with their
marker schema (#6247)
[Nazım Can Altınova] Bump the Gecko profile version to make sure that
the Text and Log marker changes are picked up in the frontends (#6252)
[fatadel] Deactivate a menu button as soon as its panel is dismissed
(#6251)
[Nazım Can Altınova] 🔃 Sync: l10n -> main (August 10, 2026) (#6253)
[Nazım Can Altınova] Bump profiler-cli version to 0.8.0 (#6254)

And special thanks to our localizers:

de: Ger
de: Michael Köhler
el: George kitsoukakis
en-CA: chutten
en-CA: Saurabh
en-GB: Ian Neal
es-CL: ravmn
fy-NL, nl: Fjoerfoks
fr: Théo Chevalier
fy-NL: Fjoerfoks
ia: Melo46
it: Francesco Lodolo [:flod]
nl: Fjoerfoks
ru: michellemelsspam
ru: Valery Ledovskoy
tr: giray
tr: Selim Şumlu
zh-TW: Pin-guang Chen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants