Skip to content
This repository was archived by the owner on Nov 15, 2019. It is now read-only.

Remove loader hotreload feature#18

Closed
juliandescottes wants to merge 1 commit intofirefox-devtools:masterfrom
juliandescottes:hotreload
Closed

Remove loader hotreload feature#18
juliandescottes wants to merge 1 commit intofirefox-devtools:masterfrom
juliandescottes:hotreload

Conversation

@juliandescottes
Copy link
Member

No description provided.

@juliandescottes
Copy link
Member Author

(adding comment from @bgrins from the email thread)

I’m in favor of removing it. By the way, I’m hoping to expose similar functionality from ./mach watch in https://bugzilla.mozilla.org/show_bug.cgi?id=1388899, which will work cross platform and for the entire frontend (including devtools).

@juliandescottes
Copy link
Member Author

(adding comment from @captainbrosset from the email thread)

Sounds good to me. Removing code always sounds good.

@juliandescottes
Copy link
Member Author

(adding comment from @sole from the email thread)

I like the idea of having a similar functionality cross platform, so this is a +1 from me

Question: didn't we want to run this kind of proposals through the process here? https://github.com/devtools-html/rfcs/

Or is it not substantial enough?

Thanks

Also YAY DELETING!

sole

@juliandescottes
Copy link
Member Author

(adding comment from @ZER0 from the email thread)

+1 for removing; especially if we're going to have a similar functionality cross platform.

@juliandescottes
Copy link
Member Author

Closing the PR in preparation for repository cleanup.

@juliandescottes juliandescottes deleted the hotreload branch September 21, 2017 17:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant