feat(snownet): restart allocations on reset keeping credentials - #14301
Merged
Conversation
thomaseizinger
force-pushed
the
feat-restart-allocations-keep-credentials
branch
from
July 24, 2026 01:34
155c3d0 to
41c2352
Compare
jamilbk
approved these changes
Jul 24, 2026
thomaseizinger
force-pushed
the
feat-hold-back-ice-candidates
branch
from
July 24, 2026 04:22
5a4e2d6 to
2978583
Compare
thomaseizinger
force-pushed
the
feat-restart-allocations-keep-credentials
branch
from
July 24, 2026 04:22
41c2352 to
1317761
Compare
thomaseizinger
force-pushed
the
feat-hold-back-ice-candidates
branch
from
July 24, 2026 05:07
2978583 to
8527ae7
Compare
thomaseizinger
force-pushed
the
feat-restart-allocations-keep-credentials
branch
from
July 24, 2026 05:07
1317761 to
67997aa
Compare
On a network reset, re-run the TURN handshake from the new socket instead of dropping the allocations entirely. The portal-issued credentials outlive the reset, so relay connectivity can recover without waiting for the portal to re-deliver the relay list.
thomaseizinger
force-pushed
the
feat-restart-allocations-keep-credentials
branch
from
July 24, 2026 06:35
67997aa to
c45c0de
Compare
thomaseizinger
enabled auto-merge
July 24, 2026 06:37
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a network reset, re-run the TURN handshake from the new socket instead of dropping the allocations entirely. The portal-issued credentials outlive the reset, so relay connectivity recovers without waiting for the portal to re-deliver the relay list.
This relies on candidates being held back and re-synced when the portal reconnects: without that, the candidates gathered during the outage are lost.
If the network reset event that connlib received was a true-positive, then we still have a hard-dependency on the portal to deliver the new candidates before we can set up a connection. If however the network reset was a false-positive due to e.g. a wake signal from the host app, re-discovering our server-reflexive candidates through the relays makes ICEless restart its probes. If we haven't roamed, then the network path is still open and we can immediately resume the connection.