Highlight redirection target as valid if it contains to-be-defined var#7695
Merged
krobelus merged 1 commit intofish-shell:masterfrom Feb 13, 2021
Merged
Conversation
krobelus
force-pushed
the
highlight-would-be-variables
branch
2 times, most recently
from
07515f7 to
bb81e52
Compare
…variable If a variable is undefined, but it looks like it will be defined by the current command line, assume the user knows what they are doing. This should cover most real-world occurrences. Closes fish-shell#6654
krobelus
force-pushed
the
highlight-would-be-variables
branch
from
bb81e52 to
88b3693
Compare
Contributor
Author
|
Whoops, I had referenced the wrong issue :c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a variable is undefined, but it looks like it will be defined by the
current command line, assume the user knows what they are doing.
This should cover most real-world occurrences.
Closes #6654
TODOs: