Skip to content

[Merged by Bors] - feat: re-add camera shake to items.#650

Closed
DRuppFv wants to merge 3 commits intofishfolk:mainfrom
DRuppFv:reimplement_camera_shake
Closed

[Merged by Bors] - feat: re-add camera shake to items.#650
DRuppFv wants to merge 3 commits intofishfolk:mainfrom
DRuppFv:reimplement_camera_shake

Conversation

@DRuppFv
Copy link
Contributor

@DRuppFv DRuppFv commented Feb 25, 2023


After this, I'll make a major PR, I just need this to be merged first.

@zicklag zicklag changed the title feat: reimplement camera shake feat: re-add camera shake to items. Feb 25, 2023
Copy link
Member

@zicklag zicklag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good. I merged fishfolk/bones#104 into bones first, and I'm pushing up my tweaks to the camera shake parameters.

Also I'm removing the camera shake on the crate for now. During testing, me and @TekhnaeRaav felt that the crate doesn't feel right shaking the ground like an explosion would.

We can tweak the prarameters more, too, if we get feedback saying it doesn't feel right.

bors merge

bors bot pushed a commit that referenced this pull request Feb 25, 2023
Co-authored-by: Zicklag <zicklag@katharostech.com>
@bors
Copy link
Contributor

bors bot commented Feb 25, 2023

@bors bors bot changed the title feat: re-add camera shake to items. [Merged by Bors] - feat: re-add camera shake to items. Feb 25, 2023
@bors bors bot closed this Feb 25, 2023
@DRuppFv
Copy link
Contributor Author

DRuppFv commented Feb 26, 2023

Thanks! This looks good. I merged fishfolk/bones#104 into bones first, and I'm pushing up my tweaks to the camera shake parameters.

Also I'm removing the camera shake on the crate for now. During testing, me and @TekhnaeRaav felt that the crate doesn't feel right shaking the ground like an explosion would.

We can tweak the prarameters more, too, if we get feedback saying it doesn't feel right.

bors merge

Ok. I've been thinking of adding camera shake on the musket (only to the shooter), but this answer made me wonder if you would use this. What do you think?

@zicklag
Copy link
Member

zicklag commented Feb 26, 2023

Yeah, I'm thinking we probably don't want to add camera shake to the musket, but I can only speak for me and @TekhnaeRaav.

@erlend-sh or @legendiguess do you have any thoughts?

@erlend-sh
Copy link
Member

Yeah during initial testing we were fine with applying the shale more liberally, but it should really just be used for explosions and other high impact weapons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants