[Merged by Bors] - feat: re-add camera shake to items.#650
[Merged by Bors] - feat: re-add camera shake to items.#650DRuppFv wants to merge 3 commits intofishfolk:mainfrom DRuppFv:reimplement_camera_shake
Conversation
There was a problem hiding this comment.
Thanks! This looks good. I merged fishfolk/bones#104 into bones first, and I'm pushing up my tweaks to the camera shake parameters.
Also I'm removing the camera shake on the crate for now. During testing, me and @TekhnaeRaav felt that the crate doesn't feel right shaking the ground like an explosion would.
We can tweak the prarameters more, too, if we get feedback saying it doesn't feel right.
bors merge
Co-authored-by: Zicklag <zicklag@katharostech.com>
|
Pull request successfully merged into main. Build succeeded: |
Ok. I've been thinking of adding camera shake on the musket (only to the shooter), but this answer made me wonder if you would use this. What do you think? |
|
Yeah, I'm thinking we probably don't want to add camera shake to the musket, but I can only speak for me and @TekhnaeRaav. @erlend-sh or @legendiguess do you have any thoughts? |
|
Yeah during initial testing we were fine with applying the shale more liberally, but it should really just be used for explosions and other high impact weapons. |
After this, I'll make a major PR, I just need this to be merged first.