Add ttl to create_moq_access - #96
Merged
Merged
Conversation
Regenerated MoqAccessConfig from fishjam openapi.yaml (fce-3832/moq-token-ttl). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013EKXgj4SvESh4S99791s1N
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are small, consistent with existing patterns (UNSET handling), and are backed by targeted tests for the new TTL behavior.
Pull request overview
This PR updates the Python SDK to support a ttl (time-to-live) parameter when generating MoQ access tokens, reflecting regenerated OpenAPI client models and adding coverage to ensure the TTL affects the returned JWT claims.
Changes:
- Added
ttlparameter toFishjamClient.create_moq_access()and wired it into the request body. - Regenerated/updated
MoqAccessConfigmodel to includettlserialization/deserialization. - Added tests validating that
ttlinfluences JWT expiry and that invalid TTL values are rejected.
File summaries
| File | Description |
|---|---|
tests/test_room_api.py |
Adds tests to validate JWT iat/exp behavior when ttl is provided and server-side validation for invalid TTL. |
fishjam/api/_fishjam_client.py |
Extends create_moq_access() with a ttl argument and passes it through to MoqAccessConfig. |
fishjam/_fishjam_openapi_client/models/moq_access_config.py |
Adds ttl field and includes it in to_dict() / from_dict() to match updated OpenAPI schema. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GZ2sxpkxEiCEjoHpXgQNEF
czerwiukk
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerated MoqAccessConfig from fishjam openapi.yaml (fce-3832/moq-token-ttl).