fix(winit): keep Linux Wayland presentation responsive - #156
Merged
zcourts merged 2 commits intoAug 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mailboxonly when the surface advertises it, withAutoVsyncas the fallbackWhy
The native shell currently presents a clear frame synchronously from
Event::Resumedand configures every surface withAutoVsync. On affected Linux Wayland software/composited WSI paths, that eager FIFO-backed presentation can wait in compositor dispatch and starve the same event loop needed to service it. After the first mapped frame, the Wayland frame callback installed byWindow::pre_present_notifycan also leave laterRedrawRequestedevents throttled indefinitely when the callback is not delivered.The winit 0.30.13 documentation specifies that
pre_present_notifyschedules this throttling callback on Wayland and is unsupported on the other native targets. The wgpu 26 present-mode documentation shows thatAutoVsyncselects FIFO/FIFO-relaxed, whileMailboxuses a replaceable single-frame queue without tearing. A related wgpu blocking report also recordsAutoVsyncblocking behavior and aMailboxworkaround.Fission already bounds redraw requests through its invalidation and frame scheduler, so this Wayland-specific callback opt-out does not introduce an idle busy loop.
Scope
Only Linux Wayland changes behavior. X11 and every other native target retain
AutoVsyncand notify-before-commit. Wayland surfaces without advertisedMailboxsupport retainAutoVsync. Web/WebGPU code paths are untouched.Validation
Mailboxselection and fallback, Wayland callback omission, and non-Wayland notify-before-commit ordering