release: glass v1.0.1 — report the real version - #190
Merged
Conversation
…ault The crate version is pinned at 0.0.0 (releases are tag-driven), so three user-facing surfaces reported a wrong version: - `glass-mcp --version` (clap) → 0.0.0 - `glass-mcp doctor`'s "glass" line → 0.0.0 - the MCP `initialize` handshake reported the transport crate's identity (rmcp / its version) via rmcp's Implementation::from_build_env default build.rs now derives the version at build time (release tag GITHUB_REF_NAME, else `git describe`, else the crate version) and emits GLASS_VERSION; a single `crate::VERSION` feeds all three surfaces, and get_info() overrides the handshake identity to glass-mcp/"glass"/VERSION. Tests pin each surface. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.0.1 — a fast-follow fixing a version-reporting defect that shipped in 1.0.0.
The bug
The crate version is pinned at
0.0.0(releases are tag-driven), so three user-facing surfaces reported the wrong version:glass-mcp --version→0.0.0glass-mcp doctor's "glass" line →0.0.0initializehandshake identified the server as the transport crate (rmcp/ its version) via rmcp'sImplementation::from_build_envdefault — so every connecting agent saw the wrong server identityThe fix
build.rsderives the version at build time (release tag viaGITHUB_REF_TYPE=tag+GITHUB_REF_NAME, elsegit describe, else the crate version) and emitsGLASS_VERSION. A singlecrate::VERSIONfeeds--version,doctor, and the handshake, andget_info()overrides the handshake identity toglass-mcp/glass/ the build-time version. Tests pin each surface.Verified: 1164 workspace tests pass; a simulated tag build reports
1.0.1, a branch build reports an honestgit describedev version (never the branch name).After merge
Tag
v1.0.1→ signed/notarized release, takes Latest.