ci: add least-privilege permissions to test and lint jobs#7
Merged
Conversation
Address CodeQL findings (#29, #30) for workflows missing an explicit permissions block. The test and lint jobs only need read access to repository contents, so scope them to contents: read. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017DWsidVYPVzvKZGq2cqrBd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the two open CodeQL code-scanning alerts (#29, #30): "Workflow does not contain permissions" (Medium) in
.github/workflows/ci.yml.The
testandlintjobs did not declare an explicitpermissionsblock, so they inherited the default (potentially write-broad)GITHUB_TOKENscope. Neither job needs more than read access to repository contents.Changes
permissions: contents: readto thetestjob.permissions: contents: readto thelintjob.The
securityjob already declares its own (contents: read+security-events: write) and is left unchanged.Notes
Applying least privilege at the job level keeps each job scoped to only what it needs, resolving both CodeQL alerts.
🤖 Generated with Claude Code
Generated by Claude Code