-
Notifications
You must be signed in to change notification settings - Fork 2
feat: notification grouping & Inhibition #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule mission-control-chart
updated
13 files
24 changes: 24 additions & 0 deletions
24
mission-control/docs/guide/notifications/concepts/grouping.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| --- | ||
| title: Grouping | ||
| sidebar_custom_props: | ||
| icon: group | ||
| --- | ||
|
|
||
| Mission Control may generate multiple related notifications within a short time window. Instead of sending each alert, | ||
| you can use notification grouping to merge multiple events into a single message. | ||
|
|
||
| _Example_: When multiple Helm releases fail to upgrade because of a common unavailable dependency, | ||
| you can use notification grouping to merge the notifications for all the affected helm releases into a single message. | ||
|
|
||
| The `groupBy` parameter lets you define how to group notifications. | ||
| You can group by: | ||
|
|
||
| - `type` (type of the config) | ||
| - `description` | ||
| - `status_reason` | ||
| - `label` in the format `label:app` | ||
| - `tag` in the format `tag:namespace` | ||
|
|
||
| ```yaml title="" file=<rootDir>/modules/mission-control/fixtures/notifications/config-health.yaml {11-12} | ||
|
|
||
| ``` |
20 changes: 20 additions & 0 deletions
20
mission-control/docs/guide/notifications/concepts/inhibition.mdx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| --- | ||
| title: Inhibition | ||
| sidebar_custom_props: | ||
| icon: block | ||
| --- | ||
|
|
||
| import Inhibition from '../../../reference/notifications/_inhibition.mdx'; | ||
|
|
||
| Multiple related notifications may be generated within a short time window. Instead of sending each alert separately, | ||
| you can use notification inhibition to inhibit notifications based on the resource hierarchy. | ||
|
|
||
| _Example_: When a Kubernetes pod becomes unhealthy, its replicaset and the deployment will also become unhealthy. | ||
| If you have a notification set up to alert on `config.unhealthy`, you'll receive 3 different notifications for the same cause. | ||
|
|
||
| ```yaml title="deployment-with-inhibition.yaml" file=<rootDir>/modules/mission-control/fixtures/notifications/deployment-with-inhibition.yaml | ||
| ``` | ||
|
|
||
| <Inhibition /> | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
mission-control/docs/reference/notifications/_inhibition.mdx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| <Fields | ||
| rows={[ | ||
| { | ||
| field: 'depth', | ||
| scheme: 'int', | ||
| description: 'Defines how many levels of child or parent resources to traverse.' | ||
| }, | ||
| { | ||
| field: 'direction', | ||
| scheme: '`inoming`|`outgoing`|`both`', | ||
| required: true, | ||
| description: 'Specifies the traversal direction in relation to the "From" resource. Can be "outgoing" (looks for child resources), "incoming" (looks for parent resources), or "all" (considers both).' | ||
| }, | ||
| { | ||
| field: 'from', | ||
| scheme: '`string`', | ||
| required: true, | ||
| description: 'Specifies the starting resource type (for example, "Kubernetes::Deployment").' | ||
| }, | ||
| { | ||
| field: 'soft', | ||
| scheme: 'bool', | ||
| description: 'When true, relates using soft relationships. Example: Deployment to Pod is hard relationship, but Node to Pod is soft relationship.' | ||
| }, | ||
| { | ||
| field: 'to', | ||
| scheme: '`[]string`', | ||
| required: true, | ||
| description: 'Specifies the traversal direction in relation to the `from` resource. `outgoing` looks for child resources and `incoming` looks for parent resources.' | ||
| } | ||
| ]} | ||
| /> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule canary-checker
updated
32 files
Submodule config-db
updated
11 files
| +19 −0 | api/v1/zz_generated.deepcopy.go | |
| +14 −1 | db/config.go | |
| +2 −2 | fixtures/kubernetes.yaml | |
| +2 −2 | fixtures/plugin-change-mapping.yaml | |
| +2 −9 | go.mod | |
| +4 −18 | go.sum | |
| +9 −1 | scrapers/aws/aws.go | |
| +11 −9 | scrapers/changes/rules.go | |
| +15 −0 | scrapers/changes/rules_test.go | |
| +0 −16 | scrapers/changes/template_utils.go | |
| +28 −6 | scrapers/kubernetes/ketall.go |
Submodule duty
updated
67 files
Submodule mission-control
updated
85 files
Submodule mission-control-chart
updated
17 files
Submodule mission-control-registry
updated
23 files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.