Skip to content

Update Translator.php - #3783

Closed
fakerybakery wants to merge 1 commit into
flarum:mainfrom
fakerybakery:patch-1
Closed

Update Translator.php#3783
fakerybakery wants to merge 1 commit into
flarum:mainfrom
fakerybakery:patch-1

Conversation

@fakerybakery

@fakerybakery fakerybakery commented Apr 5, 2023

Copy link
Copy Markdown

Changes proposed in this pull request:

  • Suppress error thrown in PHP 8.2

Reviewers should focus on:

Added @ before preg_match to fix issues with several extensions which pass null to it.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@fakerybakery
fakerybakery requested a review from a team as a code owner April 5, 2023 19:38
@luceos

luceos commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

Hello @fakerybakery,

Thanks for this PR. What error does this PR fix exactly?

@imorland

Copy link
Copy Markdown
Member

Thanks for the PR!

I noticed this recently too. However, I'd rather not simply suppress errors from preg_match. I've created an alternative solution for this in #3801, so I'll close this now.

@imorland imorland closed this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants