fix(mev-boost-relay): rbuilder now requires a relay that supports cancellations.#38
Closed
ryanschneider wants to merge 1 commit intomainfrom
Closed
fix(mev-boost-relay): rbuilder now requires a relay that supports cancellations.#38ryanschneider wants to merge 1 commit intomainfrom
ryanschneider wants to merge 1 commit intomainfrom
Conversation
ferranbt
reviewed
Feb 17, 2025
| } | ||
|
|
||
| // rbuilder now requires the relay to support bundle cancellations | ||
| if err := os.Setenv("ENABLE_BUILDER_CANCELLATIONS", "1"); err != nil { |
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Ah I hadn't pulled recently so wasn't aware of 56db5d5 👍
Contributor
Author
|
Closing as already implemented in 56db5d5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer versions of rbuilder as of flashbots/rbuilder#401 requires the relay to have cancellations enabled.
AFAICT this is only available on mev-boost-relay via setting the
ENABLE_BUILDER_CANCELLATIONSenv var.Also, now that we are on reth 1.2.0+ we can always enable the
flashbotsandmevnamespaces in--http.api.