Conversation
|
@ZanCorDX I don't know if relay respect it but we need to submit with a url param to enable this https://github.com/flashbots/geth-builder-old-unused/blob/b6a6dd336988d3f866a6c611a6505885966ba189/builder/relay.go#L142 |
Benchmark results for
|
| Date (UTC) | 2025-02-04T22:50:25+00:00 |
| Commit | 4cf7956fd36a6b87831fefaf79e3788f9f437f24 |
| Base SHA | feafa9efd9988ee039d71cdfd8cb60de555d6f47 |
Significant changes
| Benchmark | Mean | Status |
|---|---|---|
| gather_nodes_clone | -14.91% | Performance has improved. |
| MEV-Boost SubmitBlock serialization/JSON encoding | 57.96% | Performance has degraded. |
The code will never cancel, it replaces. From what I read on the relay spec (https://flashbots.github.io/relay-specs/#/Builder/submitBlock) it should work: |
| }; | ||
|
|
||
| let mut last_bid_value = U256::from(0); | ||
| let mut last_bid_hash = None; |
There was a problem hiding this comment.
nit, to make code simpler and remove this option you can set it to B256::ZERO
crates/rbuilder/src/live_builder/building/unfinished_block_building_sink_muxer.rs
Show resolved
Hide resolved
crates/rbuilder/src/live_builder/building/unfinished_block_building_sink_muxer.rs
Outdated
Show resolved
Hide resolved
crates/rbuilder/src/live_builder/building/unfinished_block_building_sink_muxer.rs
Outdated
Show resolved
Hide resolved
|
also, would it make sense to have this as a feature flag? I am not against this but there may be a problem if it does not work for some reason and we would need to quickly update builder net binary instead of config |
|
|
Changed it to use a hash from tx hashs to avoid coping stuff. |
📝 Summary
💡 Motivation and Context
Good order replacement is critical!
✅ I have completed the following steps:
make lintmake test