Skip to content

Conversation

@zeroXbrock
Copy link
Member

@zeroXbrock zeroXbrock commented Mar 4, 2025

Removes duplications from PR #54.
Since we're setting tx_type in TestScenario, we don't need to specify the tx type param in FunctionCallDefinition or CreateDefinition. Instead, we just inject the type-specific params at runtime, and based on those, the signing wallet will figure out what the tx's type should be. This saves us a lot of redundant tx_type function params.
Also replaces generator::types::TxType with alloy's consensus::TxType.

@zeroXbrock zeroXbrock merged commit 91e1eae into main Mar 4, 2025
5 checks passed
@zeroXbrock zeroXbrock deleted the brock/pr-54-edits branch March 4, 2025 23:55
@zeroXbrock zeroXbrock mentioned this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants