-
Notifications
You must be signed in to change notification settings - Fork 42
Set TxType for scenario txs
#54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
hey @zzzzzzch thanks for the PR! Sorry it took me so long to get back to you -- I recently did a bunch of refactoring and wasn't sure how this would fit until later. This is a good idea, but I think it would be even better if instead of a boolean for legacy, we had an enum to support many tx types. That way, we don't have to add additional params later on; just more enum values. The codebase has been shuffled around quite a bit since you pushed this so you might want to start this on a fresh branch and cherry-pick the code you need from this PR, but it's up to you :) Looking forward to your next commits! |
legacy option to send legacy txsTxType for scenario txs
|
finally found some time to refactor this PR, and apologize for the delay. I noticed there's also a recent PR #115 supporting 4844, and I referenced some comments from that PR during the refactoring. |
TxType for scenario txsTxType for scenario txs
|
all work is done, and some code changes such as type definitions are similar to PR #115. Therefore one of the two PRs will need to be rebased onto the other before making further changes. |
zeroXbrock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates! I like the design, just had a few minor concerns.
02d3366 to
0f99bfd
Compare
|
thanks @zzzzzzch !! |
Hi, this is a great perf tool. I found that spammer sends EIP-1559 txs by default, which is fine, but sometimes eth-forked/custom node clients may not support EIP-1559 and therefore it is needed to be specified to send legacy txs.
So this PR adds the
legacyoption to specify sending legacy txs.please review and feel free to comment.