docs(on-call): fix 37 documentation drift findings from audit#49
Merged
Conversation
Applies 37 findings from the on-call module audit (6 high, 21 medium, 10 low) against current source code in fc-event / fc-oncall / fc-foundation-app / flashduty-app. Both zh/ and en/ pages updated in lockstep. Key fixes: - Incident detail now documents all 7 tabs (previously listed 5) - Escalation rule: delay window (aggr_window) and notification template fields - Channel creation wizard: 3-step flow (was 1-step) - On-call schedule: override rules as first-class type, layer effective window, role model, day-mask defaults, personal-preference prerequisites - Alert management: stale timeline tab / close button removed; lifecycle record types, field dimensions, filter/view settings documented - Noise reduction: inhibit source corrected (active alert, not incident); quick silence default 1h; aggregation limits - Reference variables: full AlertEvent template attribute list - Filter conditions: operators and built-in attribute keys enumerated - Custom fields: field_name regex and length constraints - Personal settings: private-deployment channel gating note Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Addresses review feedback on PR #49: - Trim alert lifecycle record table to only actively-emitted feed types (a_new, a_update, a_comm, a_merge, a_m_silence, a_m_inhibit); drop deprecated or never-emitted types (a_ack/a_unack, a_snooze/a_wake, a_trans, a_close, a_m_flapping) - Remove intelligent grouping similarity threshold (i_score_threshold) from noise-reduction and outlier-incidents; not exposed in the web UI - Remove internal `frequent` outlier classification (not surfaced in UI) - Drop browser localStorage storage-key mentions from alert-management; implementation detail that users cannot act on Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc Review — 2026-04-21
Mode: audit
Scope: on-call
Findings: 37 total — 6 high, 21 medium, 10 low
Findings file:
.doc-review/findings-2026-04-21-172448.yaml(gitignored).Changes by doc page
Review checklist
Notes
README_zh.md→README.mdis unrelated to this branch.docs.jsonnot modified.🤖 Generated with Claude Code