Skip to content

fix: preserve explicit notification preference false - #55

Merged
pijiang3 merged 2 commits into
feat/notify-follow-preferencefrom
codex/fix-notify-follow-preference
Aug 12, 2026
Merged

fix: preserve explicit notification preference false#55
pijiang3 merged 2 commits into
feat/notify-follow-preferencefrom
codex/fix-notify-follow-preference

Conversation

@pijiang3

Copy link
Copy Markdown
Contributor

What changed

  • Regenerate notification override request fields as *bool, preserving explicit false on the wire.
  • Cover incident create, responder add, and incident assign requests.
  • Add the previously missing assignment notification model.
  • Add request serialization and generator regression tests.
  • Include the reviewed implementation design.

Root cause

FollowPreference was generated as bool with omitempty, so setting it to false removed follow_preference from JSON. The backend only honors personal_channels when the field is explicitly present and false.

Developer impact

This is a public Go type change. Existing keyed literals must change from FollowPreference: false to FollowPreference: flashduty.Bool(false). Publish as v0.13.0, not a patch release.

Validation

  • make check
  • golangci-lint: 0 issues
  • go test -race ./...
  • go build ./...
  • generation drift/determinism check
  • explicit-false and unset-field wire regression tests

@pijiang3
pijiang3 marked this pull request as ready for review August 12, 2026 07:35
@pijiang3
pijiang3 merged commit f7aaf75 into feat/notify-follow-preference Aug 12, 2026
4 checks passed
@ysyneu
ysyneu deleted the codex/fix-notify-follow-preference branch August 12, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant