fix: preserve explicit notification preference false - #55
Merged
pijiang3 merged 2 commits intoAug 12, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
*bool, preserving explicitfalseon the wire.Root cause
FollowPreferencewas generated asboolwithomitempty, so setting it tofalseremovedfollow_preferencefrom JSON. The backend only honorspersonal_channelswhen the field is explicitly present and false.Developer impact
This is a public Go type change. Existing keyed literals must change from
FollowPreference: falsetoFollowPreference: flashduty.Bool(false). Publish asv0.13.0, not a patch release.Validation
make checkgo test -race ./...go build ./...