systemd/system: add sshkeys@.service - #103
Merged
Merged
Conversation
4 tasks
pothos
reviewed
Sep 7, 2023
|
|
||
| [Install] | ||
| WantedBy=multi-user.target | ||
| DefaultInstance=core |
Member
There was a problem hiding this comment.
Do we really need the @ parameterization? I think that users would directly enable coreos-metadata-sshkeys@USER.service for any other users they want to have instead of enabling sshykeys@USER to have this start the other one.
Member
There was a problem hiding this comment.
So, would just sshkeys.service be enough with Upholds=coreos-metadata-sshkeys@core.service hardcoded?
pothos
approved these changes
Sep 7, 2023
pothos
left a comment
pothos
left a comment
Member
There was a problem hiding this comment.
One question but even in the current state it's good
this service allows to conditionnally start the `coreos-metadata-sshkeys@.service` on DO, EM, EC2 and GGE with the default `core` instance in order to control the `coreos-metadata-sshkeys@.service` from the generic image and not from the OEM. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/sshkeys
branch
from
September 8, 2023 07:35
68a21a0 to
9bebd6c
Compare
Member
|
It still has the |
Contributor
Author
|
ah 🤦 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this service allows to conditionnally start the
coreos-metadata-sshkeys@.serviceon DO, EM, EC2 and GGE with the defaultcoreinstance in order to control thecoreos-metadata-sshkeys@.servicefrom the generic image and not from the OEM.See: flatcar/scripts#1083 for context, CI and cie.