sys-boot/grub: update to 2.06 - #1082
Merged
Merged
Conversation
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
It's from Gentoo commit 97daf89c0e60fa163c04990d17635cdebd83e579.
sayanchowdhury
had a problem deploying
to
development
August 24, 2023 08:00 — with 
GitHub Actions
Error
GitHub Actions
Error
Member
Author
|
Another fresh CI builds with the accomodated patches: http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/1013/ |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/5961101552 |
jepio
approved these changes
Aug 24, 2023
jepio
left a comment
jepio
left a comment
Member
There was a problem hiding this comment.
lgtm - lets review the getenv thing when we update shim and get secure boot working.
krnowak
approved these changes
Aug 25, 2023
sayanchowdhury
had a problem deploying
to
development
August 25, 2023 09:21 — with
GitHub Actions
Error
GitHub Actions
Error
sayanchowdhury
had a problem deploying
to
development
August 25, 2023 09:22 — with
GitHub Actions
Error
GitHub Actions
Error
sayanchowdhury
had a problem deploying
to
development
August 25, 2023 09:22 — with
GitHub Actions
Error
GitHub Actions
Error
sayanchowdhury
had a problem deploying
to
development
August 25, 2023 09:22 — with
GitHub Actions
Error
GitHub Actions
Error
sayanchowdhury
had a problem deploying
to
development
August 25, 2023 09:22 — with
GitHub Actions
Error
GitHub Actions
Error
sayanchowdhury
had a problem deploying
to
development
August 25, 2023 09:22 — with
GitHub Actions
Error
GitHub Actions
Error
sayanchowdhury
had a problem deploying
to
development
August 25, 2023 09:22 — with
GitHub Actions
Error
GitHub Actions
Error
sayanchowdhury
had a problem deploying
to
development
August 25, 2023 09:23 — with
GitHub Actions
Error
GitHub Actions
Error
sayanchowdhury
had a problem deploying
to
development
August 25, 2023 09:23 — with
GitHub Actions
Error
GitHub Actions
Error
Co-authored-by: Krzesimir Nowak <knowak@microsoft.com> Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
sayanchowdhury
force-pushed
the
sayan/update-grub-2.06-back
branch
from
August 25, 2023 09:27
c923c25 to
c1aae63
Compare
sayanchowdhury
had a problem deploying
to
development
August 25, 2023 09:28 — with
GitHub Actions
Failure
GitHub Actions
Failure
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sys-boot/grub: update to 2.06
Fixes flatcar/Flatcar#1099
Testing done
CI Passed (except for few arches) http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/1009/cldsv/
CI Running
http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/1013/cldsv/
Reviews from the previous PR flatcar-archive/coreos-overlay#2098
@krnowak
sys-boot/grub: sync with gentoo upstream; updates to 2.06 flatcar-archive/coreos-overlay#2098 (comment) - Fixed
sys-boot/grub: sync with gentoo upstream; updates to 2.06 flatcar-archive/coreos-overlay#2098 (comment) - Fixed
sys-boot/grub: sync with gentoo upstream; updates to 2.06 flatcar-archive/coreos-overlay#2098 (comment) - This seems to be required, and this is required to construct IUSE, and MULTIBUILD variant used in the ebuild
sys-boot/grub: sync with gentoo upstream; updates to 2.06 flatcar-archive/coreos-overlay#2098 (comment) - Fixed this
@pothos
sys-boot/grub: sync with gentoo upstream; updates to 2.06 flatcar-archive/coreos-overlay#2098 (comment) - I've fixed the commits, and have added a README.md file adding a bit of context as well as the list of commits picked.
sys-boot/grub: sync with gentoo upstream; updates to 2.06 flatcar-archive/coreos-overlay#2098 (comment) - Tested and looks good, the downgrade worked successfully but did not affect the grub, which stayed at 2.06
Changelog entries added in the respective
changelog/directory (user-facing change, bug fix, security fix, update)Inspected CI output for image differences:
/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.