fix: defer variable expansion in gc-sdk aliases - #4210
Merged
Conversation
chewi
approved these changes
Aug 12, 2026
chewi
left a comment
chewi
left a comment
Contributor
There was a problem hiding this comment.
Good catch. I think HOME is unlikely to be an issue in practise, but it should be quoted. Much more importantly though, PWD will almost certainly be wrong without this fix.
chewi
requested changes
Aug 12, 2026
chewi
left a comment
chewi
left a comment
Contributor
There was a problem hiding this comment.
Wait, a stray ` has snuck in at the end.
Wrap docker aliases in single quotes to evaluate $PWD and $HOME at execution time rather than when the script is sourced. Signed-off-by: Harsh Dahiya <dahiyaharsh2005@gmail.com>
Contributor
Author
|
Sorry for that. Fixed. |
chewi
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX
Wrap aliases in single quotes to evaluate $PWD and $HOME at execution time rather than when the script is sourced.
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.