Merge branch 'master' into beta #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request flathub#61 from eunos-1128/beta
Merge pull request flathub#75 from eunos-1128/master
- Replaced `--filesystem=home` with `--filesystem=host` - Added `--filesystem=xdg-cache` and `--filesystem=xdg-data`
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
There was a problem hiding this comment.
Pull Request Overview
This pull request merges changes from the master branch into the beta branch, focusing on improvements to the Flatpak build configuration and documentation. The changes standardize patch file organization, update installation instructions, and address build process issues.
- Reorganized patch files into a dedicated
patches/directory for better maintainability - Updated Flatpak installation commands to use the
--userflag for user-level installations - Added a new patch to fix build issues related to the
monomerssubdirectory
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
patches/Makefile.am.patch |
New patch file that adds the missing monomers subdirectory to the build process and removes trailing whitespace |
io.github.pemsley.coot.yaml |
Updated patch paths to use the patches/ directory, renamed module from clipper4coot to clipper, removed unnecessary mkdir command, and added reference to the new Makefile.am patch |
README.md |
Updated Flatpak installation commands to include the --user flag for both stable and beta versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
✅ Test build succeeded. To test this build, install it from the testing repository: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily updates the Flatpak build configuration and related documentation for the project, focusing on improving patch management, clarifying installation instructions, and fixing minor issues with the build process. The most important changes are grouped below:
Documentation Updates:
README.mdto use the--userflag, ensuring the remote is added for the current user rather than system-wide. [1] [2]Patch Management and Build Configuration:
io.github.pemsley.coot.yamlby moving patch paths into apatches/directory for consistency and clarity. [1] [2] [3]Makefile.amin the build process, referencing a specific upstream issue for context. [1] [2]Build Process Improvements:
clipper4cootmodule toclipperin the Flatpak manifest to accurately reflect the dependency.mkdircommand from the post-install steps in the Flatpak manifest, as the target directory is already created by the subsequent copy command.